FIX QuerySort::sort method should support sorting for multi arguments #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2023
sabina-talipova
force-pushed
the
pulls/4.3/fix-broken-sort-order
branch
from
eacca89 to
438c1a1
Compare
sabina-talipova
commented
Nov 23, 2023
| @@ -631,6 +668,62 @@ public function testFieldAliases() | |||
| $this->assertResult('readOneDataObjectFake.author', null, $result); | |||
| } | |||
|
|
|||
| public function provideFilterAndSortOnlyRead(): array | |||
There was a problem hiding this comment.
I'll add one more test case for SortPlugin here.
sabina-talipova
force-pushed
the
pulls/4.3/fix-broken-sort-order
branch
7 times, most recently
from
5f2f79c to
64bdd35
Compare
sabina-talipova
commented
Nov 23, 2023
| @@ -7,7 +7,7 @@ | |||
| "php": "^7.4 || ^8.0", | |||
| "silverstripe/framework": "^4.11", | |||
| "silverstripe/vendor-plugin": "^1.0", | |||
| "webonyx/graphql-php": "^14.0", | |||
| "webonyx/graphql-php": "^14.11", | |||
There was a problem hiding this comment.
We need this to pass --prefer-lowest CI. Since in 14.0.0 FieldDefinition doesn't have getName() method
GuySartorelli
requested changes
Nov 23, 2023
sabina-talipova
force-pushed
the
pulls/4.3/fix-broken-sort-order
branch
from
64bdd35 to
5781c46
Compare
GuySartorelli
approved these changes
Nov 23, 2023
2 tasks
2 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even if a method receives several parameters, then sorting occurs by the field of the arguments that is last specified in the schema, and not in the passed parameters. That is, if
SilverStripe\GraphQL\Tests\Fake\DataObjectFakehas the following schemaand sorting is required
AuthorID => DESC, myField => ASC, then sorting was done only byAuthorID, since in the schema this field is indicated after myField.Therefore, the call
$list->sort()must be completed after all the necessary processing has been carried out.Parent issue